Skip to content

Conversation

@sand4rt
Copy link

@sand4rt sand4rt commented Nov 21, 2025


@stylix-automation stylix-automation bot added topic: home-manager Home Manager target topic: modules /modules/ subsystem labels Nov 21, 2025
@stylix-automation stylix-automation bot requested a review from trueNAHO November 21, 2025 19:52
@trueNAHO trueNAHO changed the title fix: color scheme isn’t applied to the progress bar dunst: set highlight color Nov 22, 2025
Copy link
Member

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this option not deprecated:

   DEPRECATED OPTIONS
       Old  version  of  dunst  allowed changing the colors of different
       urgencies through command line options. This has been long removed in
       favour of RULES, see issue #328.

       -li/ni/ci icon
           Set notification icon.

       -lf/nf/cf color
           Set notification foreground color.

       -lb/nb/cb color
           Set notification background color.

       -lh/nh/ch color
           Set notification highlight color.

       -lfr/nfr/cfr color
           Set notification frame color.

       -lto/nto/cto secs
           Set notification timeout time.

-- dunst(1)

Could you show what this improves with a screenshot and provide a reproducible command?

@sand4rt
Copy link
Author

sand4rt commented Nov 22, 2025

with highlight = base0D;:

image

without:

image

command:

notify-send -h int:value:45 "Progress Test" "At 50%"

Copy link
Member

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebasing this PR on top of #2021, shows that dunst already applies the correct color based on the urgency:

Before After
notify-before notify-after

This patch nullifies this feature, which is undesirable. Should the highlight colors not be based on the urgency color?

@sand4rt
Copy link
Author

sand4rt commented Nov 25, 2025

This patch nullifies this feature, which is undesirable. Should the highlight colors not be based on the urgency color?

Alright, i'll close this one. My preference would be to keep the progress bar consistent regardless of urgency level, since the urgency is already communicated clearly enough.

@sand4rt sand4rt closed this Nov 25, 2025
@trueNAHO
Copy link
Member

trueNAHO commented Nov 26, 2025

This patch nullifies this feature, which is undesirable. Should the highlight colors not be based on the urgency color?

Alright, i'll close this one.

Since these highlight colors seem hard-coded, it would still be nice to have them properly match the urgency color. I suppose in this case, it should match the border color (frame_color). This is done in #2032.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: home-manager Home Manager target topic: modules /modules/ subsystem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants